Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routing): use graphhopper to provide GTFS based public transport routing #441

Merged
merged 13 commits into from
Jan 9, 2025
Merged

feat(routing): use graphhopper to provide GTFS based public transport routing #441

merged 13 commits into from
Jan 9, 2025

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Nov 29, 2024 •
edited
Loading

Description

A new routing interface for finding public transport routes.

Open issues:

  • test with larger GTFS
  • approve graphhopper-reader-gtfs
  • approve io.mobilitydata.transit:gtfs-realtime-bindings
  • approve org.mapdb:mapdb
  • approve javacsv - it's LGPL and I cannot find its source code :( approve opencsv

Issue(s) related to this PR

  • Partly resolves internal issue 955

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

schwepmo
schwepmo requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new feature! However, I think there is some refactoring necessary before merging this PR.

...ipse/mosaic/fed/application/ambassador/simulation/navigation/CentralNavigationComponent.java Outdated Show resolved Hide resolved
...lication/src/main/java/org/eclipse/mosaic/fed/application/config/CApplicationAmbassador.java Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/config/CVehicleRouting.java Outdated Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/pt/MultiModalLeg.java Outdated Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/pt/MultiModalLeg.java Outdated Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/pt/PtRouting.java Outdated Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/pt/PtRouting.java Show resolved Hide resolved
lib/mosaic-routing/src/main/java/org/eclipse/mosaic/lib/routing/pt/PtRouting.java Show resolved Hide resolved
lib/mosaic-routing/src/test/java/org/eclipse/mosaic/lib/routing/pt/PtRoutingTest.java Show resolved Hide resolved
lib/mosaic-routing/src/test/java/org/eclipse/mosaic/lib/routing/pt/PtRoutingTest.java Outdated Show resolved Hide resolved
@kschrab
Copy link
Contributor Author

kschrab commented Dec 11, 2024

@schwepmo I also added a small UNITS class for conversion of kmh to meters per second

@kschrab kschrab requested a review from schwepmo December 11, 2024 13:11
@kschrab kschrab added the enhancement New feature or request label Dec 11, 2024
@kschrab kschrab force-pushed the 955-public-transport-routing branch from a8aaca0 to 3e0229a Compare December 11, 2024 13:51
@kschrab kschrab marked this pull request as ready for review January 6, 2025 13:39
@kschrab kschrab requested a review from schwepmo January 6, 2025 13:39
@kschrab
clean(routing): work after review
e63a3c4 
* rename Routing to VehicleRouting
* improved documentation
@schwepmo
Copy link
Contributor

schwepmo commented Jan 8, 2025

There are two minor threads unresolved. After looking at these I am happy to approve and merge this PR

@kschrab
Copy link
Contributor Author

kschrab commented Jan 9, 2025

There are two minor threads unresolved. After looking at these I am happy to approve and merge this PR

done

@kschrab kschrab merged commit 2cf33c8 into main Jan 9, 2025
5 checks passed
@kschrab kschrab deleted the 955-public-transport-routing branch January 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwepmo schwepmo schwepmo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kschrab @schwepmo